search

brenden / node-webshot

Easy website screenshots in Node.js
2.12k stars 286 forks source link

errorIfJSException is not working as expected #124

Closed palamccc closed 8 years ago

palamccc commented 8 years ago

errorIfJSException don't have any effect on error messages emitted by phantomjs page.

https://github.com/brenden/node-webshot/blob/08ef191f73bab4687c4f982df4671cdec50437d0/lib/webshot.phantom.js#L18-L29

From commits, i understand this feature is under development, I'm just creating issue, for your information.

palamccc commented 8 years ago

I was testing against last release 0.16.0 (six months old), looks like errorIfJSException is implemented only on master branch, and not yet released. so closing the issue, if possible, keep two READMEs, one for stable release, one for dev branch.