brenden / node-webshot

Easy website screenshots in Node.js
2.12k stars 286 forks source link

Version of graceful-fs deprecated #139

Open ghost opened 8 years ago

ghost commented 8 years ago

Installing webshot using npm shows the following warning about graceful-fs:

npm WARN deprecated graceful-fs@3.0.8: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.

It looks like it's a little more than a warning.

nikhiljha commented 8 years ago

+1 This should be fixed, it's always good to update this stuff. I'd make a pull request, but it's such an easy fix (literally edit the package.json and then (if necessary) fix calls to graceful-fs).

olalonde commented 8 years ago

+1. This module now breaks on Node v6.0.0 😢

(node:90393) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
olalonde commented 8 years ago

@brenden can we bump graceful-fs plz 😿

tomerb15 commented 8 years ago

+1

nikhiljha commented 8 years ago

150 fixes this

bernardofd commented 8 years ago

While #150 is not merged, you can force the up-to-date version of graceful-fs into webshot by including a npm-shrinkwrap.json file in your app root directory:

{
  "name": "Your App Name",
  "version": "X.X.X",
  "dependencies": {
    "webshot": {
      "version": "0.18.0",
      "from": "webshot@>=0.18.0 <0.19.0",
      "resolved": "https://registry.npmjs.org/webshot/-/webshot-0.18.0.tgz",
      "dependencies": {
        "graceful-fs": {
          "version": "4.1.4",
          "from": "graceful-fs@latest",
          "resolved": "https://registry.npmjs.org/graceful-fs/-/graceful-fs-4.1.4.tgz"
        }
      }
    }
  }
}

npm will use the latest version of graceful-fs instead of the one supplied by the package.json.

vgoloviznin commented 8 years ago

Any estimate on when it will be merged? :)