search

brenden / node-webshot

Easy website screenshots in Node.js
2.12k stars 286 forks source link

bumps graceful-fs to avoid node>= v6 breakage #150

Closed makepanic closed 11 months ago

makepanic commented 8 years ago

Using node-webshot as a dependency, i get the following deprecation warning:

npm WARN deprecated graceful-fs@3.0.8: graceful-fs v3.0.0 and before will fail on node releases >= v6.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

running npm ls graceful-fs, i found that node-webshot uses the deprecated graceful-fs version

└─┬ webshot@0.18.0
  └── graceful-fs@3.0.8

To fix the deprecation warning, i installed the current graceful-fs version

dcohenb commented 8 years ago

If anyone runs into this issue you can install from the pull request as a temporary solution: npm i -S github:brenden/node-webshot#pull/150/head

olalonde commented 8 years ago

@brenden can we merge this plz :)

revelt commented 7 years ago

Half a year has passed, should we merge?

olalonde commented 7 years ago

node-webshot is more or less deprecated now, there are better packages like https://github.com/sindresorhus/pageres for taking web page screenshots now. Personally, I'm using https://github.com/alexscheelmeyer/node-phantom