search

brenden / node-webshot

Easy website screenshots in Node.js
2.12k stars 285 forks source link

`primordials` is not defined - Node v12 #240

Open JMTK opened 5 years ago

JMTK commented 5 years ago 
ReferenceError: primordials is not defined
    at fs.js:27:35
    at req_ (node_modules/natives/index.js:143:24)
    at Object.req [as require] (node_modules/natives/index.js:55:10)
    at Object.<anonymous> (node_modules/webshot/node_modules/graceful-fs/fs.js:1:37)

I'm using the webshot modules but it's the inner workings of the graceful-fs. I tried upgrading it to 4.x and it works fine so I think that's the ticket

zoness32 commented 5 years ago

I can confirm this fixes the issue.

Created a PR to fix this: https://github.com/brenden/node-webshot/pull/243

architjn commented 4 years ago

Seems like the project is not being updated since 2016. So I have created a project clone solving this issue.

GitHub - https://github.com/architjn/node-webshot npmjs - https://www.npmjs.com/package/webshot-node

juanpmd commented 4 years ago

Seems like the project is not being updated since 2016. So I have created a project clone solving this issue.

GitHub - https://github.com/architjn/node-webshot npmjs - https://www.npmjs.com/package/webshot-node

Amazing, it works perfectly. Thank you

itzBawantha commented 4 years ago

Seems like the project is not being updated since 2016. So I have created a project clone solving this issue.

GitHub - https://github.com/architjn/node-webshot npmjs - https://www.npmjs.com/package/webshot-node

Thank you amazing work