search

brenden / node-webshot

Easy website screenshots in Node.js
2.12k stars 285 forks source link

error with special chars resolved (düsseldorf.de has made a webshot of d... #66

Closed ManAnRuck closed 10 years ago

ManAnRuck commented 10 years ago

error with special chars resolved (düsseldorf.de has made a webshot of dsseldorf.de)

brenden commented 10 years ago

Looks good :thumbsup:

ecalvert commented 10 years ago

This change breaks urls that have been encoded already. For example, when using the google doc viewer:

http://docs.google.com/viewer?url=http%3A%2F%2Fhost.com%2Fsomedocfile.doc%3Fmode%3Dsomething%26foo%3Dbar

The query string will be escaped twice and break the url parameter in the querystring. I think it should be up to the developer to pass in well-formed url.

brenden commented 10 years ago

Yeah that's right, should have thought this through better before merging. OK I'm reverting this.