search

brenden / node-webshot

Easy website screenshots in Node.js
2.12k stars 286 forks source link

Update webshot.phantom.js to add cookies to the phantom object. #77

Closed LorenzGardner closed 10 years ago

LorenzGardner commented 10 years ago

This will now properly render the page with document.cookie set

LorenzGardner commented 10 years ago

This should address #76 and #70

brenden commented 10 years ago

Makes sense: we need to call phantom.addCookie for each cookie instead of just setting the cookies array directly. Thanks for fixing this.

brenden commented 10 years ago

GH isn't showing this as merged because I ammended your commit message, but it has actually been merged in 03a89ac