brenden / node-webshot

Easy website screenshots in Node.js
2.12k stars 286 forks source link

Replace child_process with cross-spawn #93

Closed jamesryanbell closed 9 years ago

jamesryanbell commented 9 years ago

This means that the library now works on Windows and Mac (haven't tested on Unix) more reliably. Also Updated the .gitignore file so that I don't commit .ds_store files.

I have run the tests and there is no difference to the output between child_process and cross-spawn so everything should be fine.

Thanks, James

brenden commented 9 years ago

Thanks!