search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.04k stars 355 forks source link

Update list.rb #197

Closed sandergroen closed 8 years ago

sandergroen commented 8 years ago

Passing string to define callback is deprecated and will be removed in Rails 5.1 without replacement.

brendon commented 8 years ago

Sneaky colon! :) Was Rails complaining about that, or were you using a different version of the gem?

sandergroen commented 8 years ago

I pinned the Gemfile to the master branch. It does not matter if you use a colon or to_sym the deprecation warning is the same for both.

brendon commented 8 years ago

That's weird. Is that a bug with their deprecation detection? I see they're just doing if filter.is_a?(String). Can you double check that you're using the correct version of aal? It could be that your tests are running against an old version? We did the symbol thing because of the deprecation warning already. That's all I can think of that might be going wrong.