search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.05k stars 356 forks source link

Start testing Rails 5 #203

Closed brendon closed 8 years ago

brendon commented 8 years ago

There are plenty of failing tests, deprecations, and warnings. At least this works as a starting point for getting these ironed out.

brendon commented 8 years ago

Ok, I've cleared out the deprecations and other warnings. Now it's just the actual failing tests, and I'm almost certain it has to do with the attribute swapper functionality. Probably to do with the usage of the internal variable. I'll try to see if we can work around that.

brendon commented 8 years ago

Hi @swanandp, tests are green. I've made the attribute swapping better in my opinion. We're no longer using an undocumented internal variable. I didn't check, but I think that variable name probably changed between versions. This change is better since we're now using only the external interface. I've also dropped the extra swap_attributes method since we're only doing this in one place, it make sense to just do it there.

brendon commented 8 years ago

I've decided to merge this. Everything seems to be working.