search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.04k stars 355 forks source link

Failing example for #153 #204

Closed afn closed 7 years ago

brendon commented 8 years ago

Thanks for this, could you rebase it please and check that the bug still exists? Also, the CI tests are failing due to an arity problem. Can you fix that up too please? It could be that you have to adjust your tests to take into account that we test against Rails 3.2+

brendon commented 8 years ago

Hi @afn, can you rebase this?

afn commented 8 years ago

Rebased against master.

brendon commented 8 years ago

Thanks @afn, the test suite seems to be failing due to a syntax error. Can you see if you can get it to run again? See the Travis results below.

brendon commented 8 years ago

@afn, your ActiveRecord::Base.logger = Logger.new STDOUT line is causing an error. Might have to make it absolute ::Logger :)

afn commented 8 years ago

Sorry for the delay — fixed the syntax error.

brendon commented 8 years ago

Thanks @afn. The tests are still failing unfortunately. Try rebasing (as a lot has changed recently), then run appraisal install and then appraisal rake. That'll run the tests across all four framework versions. All of the versions are failing though, so feel free to figure out one first, then test the rest. Travis will also then test across though plus our supported Rubies.