search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.04k stars 355 forks source link

Bug: Specifying a position with add_new_at: :top fails to insert at that position #220

Closed brendon closed 8 years ago

brendon commented 8 years ago

I've created a test that confirms the bug. Now I guess we figure out how to fix it.

brendon commented 8 years ago

Hi fella's. I'd like some feedback on this one as it breaks currently tested behaviour, though the existing behaviour is weird to begin with. Let me know if you need any more details. I suppose we'd bump the minor version if we released this?

swanandp commented 8 years ago

rbx failures are weird. I will look into them.

brendon commented 8 years ago

Yes, they seem to be intermittent? Or perhaps I'm thinking of another time. Thanks for taking a look. I don't use Rubinius so I'm not sure what's going on :)

brendon commented 8 years ago

Perhaps we're testing against an old version of rbx that is buggy? Is this one equivalent to mri2.1.0?

brendon commented 8 years ago

Just closed and reopened this one to see if the rbx test failure was transient.

brendon commented 8 years ago

Hi @swanandp, Rubinius seems to be a bit flaky with travis-ci. The latest test run just failed outright on installing the gems. Should we look at dropping support for that particular ruby franchise? It's certainly causing uncertainty in development.

brendon commented 8 years ago

Scratch that, it seems it's to do with the extra gems we're specifying for rbx. I've removed them in a PR: #225 so we'll see how that builds. I'll then update this with that and see.

brendon commented 8 years ago

This is super frustrating. One pass and one failure, same code! :) And nothing major changed between versions :( Do we just go ahead and merge this @swanandp, and put it down to a bad travis stack?

swanandp commented 8 years ago

This looks like an interesting problem to tack down, but let's go ahead an merge this, since this is the right way to go.

On Tue, Aug 23, 2016 at 3:01 AM, Brendon Muir notifications@github.com wrote:

This is super frustrating. One pass and one failure, same code! :) And nothing major changed between versions :( Do we just go ahead and merge this @swanandp https://github.com/swanandp, and put it down to a bad travis stack?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/swanandp/acts_as_list/pull/220#issuecomment-241557308, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFjGLW9dnQ0zbYDA_Dut-SLtmfryzd7ks5qihUhgaJpZM4Jj16J .

brendon commented 8 years ago

Yea, I've emailed the travis support team. See the Rails 4.1 test passed in the last run, then the 5.0 test failed! I think it's some instability on their end honestly. I'll merge this and do an 0.8.0 release.

brendon commented 8 years ago

0.8.0 has been released and includes this change.