search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.05k stars 356 forks source link

Fix position when no serial positions #223

Closed jpalumickas closed 8 years ago

jpalumickas commented 8 years ago

Opened branch from https://github.com/swanandp/acts_as_list/pull/208 to fix tests and rebase to master branch.

Can you take a look @brendon ?

jpalumickas commented 8 years ago

@brendon There is one test failing, I think it's random fail, can you restart a build for this pull request ?

jpalumickas commented 8 years ago

I restarted a build with amend, now it's passing. It was a random fail.

brendon commented 8 years ago

Thanks @jpalumickas, I just had a couple of queries. If we can settle those then I think this can be merged :) Closes #208 (replaced by this PR).

brendon commented 8 years ago

Just a note. I have another possibly compatibility-breaking change here: https://github.com/swanandp/acts_as_list/pull/220 so it might make sense to bump the minor version to 0.8.0 to take both of these two changes into account. At least people will then double-think blindly upgrading. We should probably document these changes in the README with an upgrade message.

swanandp commented 8 years ago

Agree on both counts, version bump and doc updates

On Sun, Aug 21, 2016 at 2:13 PM, Brendon Muir notifications@github.com wrote:

Just a note. I have another possibly compatibility-breaking change here:

220 https://github.com/swanandp/acts_as_list/pull/220 so it might make

sense to bump the minor version to 0.8.0 to take both of these two changes into account. At least people will then double-think blindly upgrading. We should probably document these changes in the README with an upgrade message.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/swanandp/acts_as_list/pull/223#issuecomment-241245843, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFjGFYGAyJXtXJuKFzmNnKMrzr_Zkl8ks5qiA-agaJpZM4JoVvT .

brendon commented 8 years ago

0.8.0 has been released and includes this change.

jpalumickas commented 8 years ago

Perfect, thanks 👍

PoslinskiNet commented 8 years ago

Nice 👍