DEPRECATION WARNING on rails 5.0 as of acts_as_list 0.9

brendon / acts_as_list

An ActiveRecord plugin for managing lists.

http://brendon.github.io/acts_as_list/

MIT License

2.05k stars 356 forks source link

DEPRECATION WARNING on rails 5.0 as of acts_as_list 0.9 #251

Closed jhawthorn closed 7 years ago

jhawthorn commented 7 years ago

Since upgrading to 0.9.0, I've been seeing this deprecation error on Rails 5.0.1:

DEPRECATION WARNING: #table_exists? currently checks both tables and views. This behavior is deprecated and will be changed with Rails 5.1 to only check tables. Use #data_source_exists? instead.

The call to table_exists was added here

brendon commented 7 years ago

Thanks @jhawthorn :)

@zharikovpro would you mind looking into how we can avoid this warning? Should just be a fork in the logic there I guess. I think we may have already done this elsewhere in the code already.

zharikovpro commented 7 years ago

@brendon yes, will take a look and prepare PR. Should be an easy fix.

brendon commented 7 years ago

All fixed @jhawthorn :) Thanks again @zharikovpro!