search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.04k stars 355 forks source link

Refactor column definer module #258

Closed ledestin closed 7 years ago

ledestin commented 7 years ago

Tidy up ColumnMethodDefiner - extract some methods and other changes.

swanandp commented 7 years ago

I am generally skeptical about merging pure refactoring PRs, unless they serve a specific purpose. But this refactoring is looking good, and makes the code a lot more readable.

@brendon Unless you have any objections, we can merge this.

brendon commented 7 years ago

Thanks @swanandp, @ledestin does some work for me as a contractor and is using this gem in his blog about refactoring. I think this is just continuing on from his work last year around splitting out the acts_as_list mega-method into more logical blocks. I'm happy to merge it too. :)