search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.05k stars 356 forks source link

Refactor update_all_with_touch #279

Closed ledestin closed 7 years ago

ledestin commented 7 years ago

Hi,

I've refactored update_all_with_touch. If you're curious to know the reasons for my choices, I explain everything in a blog post: https://rubyclarity.com/2017/06/acts_as_list-refactoring-part-3/

brendon commented 7 years ago

Hi @ledestin, I think this is ok. @swanandp, did you have any thoughts?

brendon commented 7 years ago

Thanks @swanandp, we can actually do this for him with the Squash and merge button if you like?

swanandp commented 7 years ago

@brendon I am inclined to give him a choice. What do you think?

brendon commented 7 years ago

Oh yes definitely. I was just meaning he doesn't have to do the squash himself if he wants it to go that way :)

ledestin commented 7 years ago

@swanandp @brendon I'm ok with the way it suits you, it's your project after all. Feel free to squash.