search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.04k stars 355 forks source link

Fix Fixnum deprecation warnings. #282

Closed patrickdavey closed 7 years ago

patrickdavey commented 7 years ago

Fixnum is being deprecated and merged with Bignum into Integer (http://blog.bigbinary.com/2016/11/18/ruby-2-4-unifies-fixnum-and-bignum-into-integer.html)

This PR replaces Fixnum with Integer (in the tests) and fixes the deprecation warnings

brendon commented 7 years ago

Excellent! :) Thanks @patrickdavey.

krzysiek1507 commented 7 years ago

What's the file file:memdb1?mode=memory&cache=shared? ;)

brendon commented 7 years ago

I can't quite remember but you can use the blame feature of github to find out what the related commit was. I think it was to do with simulating race conditions.

krzysiek1507 commented 7 years ago

It has been added with this PR and it looks like SQLite file.

brendon commented 7 years ago

Not according to the files list: https://github.com/swanandp/acts_as_list/pull/282/files

krzysiek1507 commented 7 years ago

I can see it.

screenshot-github com 2017-07-02 23-02-56

brendon commented 7 years ago

Ah I see! Sorry it doesn't really stand out at all in the list does it. I've committed a removal directly to master.

krzysiek1507 commented 7 years ago

No problem! Thanks!

patrickdavey commented 7 years ago

My apologies for that :( I should have been more careful, usually am but it slipped through! Thanks @krzysiek1507 for pointing that out, and @brendon for fixing it.

brendon commented 7 years ago

Hey no worries :D We haven't released a gem yet anyway :)