search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.04k stars 355 forks source link

Skip needless position-increments when creating with explicit positions #292

Closed fnordfish closed 6 years ago

fnordfish commented 6 years ago

This is some work in progress for #289 (see: https://github.com/swanandp/acts_as_list/issues/289#issuecomment-342457941)

There are probably a ton of tests missing to make this an actual fix. The underlying problem is, that when inserting a new "higher" position triggers an increment of all "lower" ones (pushing them even lower). Which makes sense, if that new position would collide with an existing one. But if the spot is free, there's no need to change anything.

brendon commented 6 years ago

Hey bro, that's a good start :) Keep going :D

brendon commented 6 years ago

@fnordfish, were you still wanting to progress this? I'll close it otherwise :)

fnordfish commented 6 years ago

Hey. Probably, I won’t find the time in the near future. Close away :)

From: Brendon Muir notifications@github.com(mailto:notifications@github.com) Reply: swanandp/acts_as_list reply@reply.github.com(mailto:reply@reply.github.com) Date: 19. March 2018 at 17:24:26 To: swanandp/acts_as_list acts_as_list@noreply.github.com(mailto:acts_as_list@noreply.github.com) CC: Robert Schulze robert@dotless.de(mailto:robert@dotless.de), Mention mention@noreply.github.com(mailto:mention@noreply.github.com) Subject: Re: [swanandp/acts_as_list] Skip needless position-increments when creating with explicit positions (#292)

@fnordfish(https://github.com/fnordfish), were you still wanting to progress this? I'll close it otherwise :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub(https://github.com/swanandp/acts_as_list/pull/292#issuecomment-374121975), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAAyJ0uFFrL-56e8i7Yd_cAcbUnRWi3fks5tf10qgaJpZM4Qoil6).

brendon commented 6 years ago

All good bro. You're welcome back any time :)