search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.05k stars 356 forks source link

Add frozen_string_literal pragma to ruby files #305

Closed krzysiek1507 closed 6 years ago

krzysiek1507 commented 6 years ago

According to this blog post: https://www.mikeperham.com/2018/02/28/ruby-optimization-with-one-magic-comment/

brendon commented 6 years ago

Thanks @krzysiek1507 :D

krzysiek1507 commented 6 years ago

TravisCI fails on Rails 5.2 and MySQL but it also fails on master.

swanandp commented 6 years ago

I just checked, Rails 5.2 is a different issue not related to this one.

brendon commented 6 years ago

We seem to be having suite failures for Rails 5.2 and certain rubies. I think it might be to do with rake versions? or something like that. I don't have time to look into it this weekend, but if either of you two can that would be cool :)

krzysiek1507 commented 6 years ago

The problem is mysql2. It is old and doesn't work with Rails 5.2 but 0.4.10 doesn't work with Rails < 4.2.

brendon commented 6 years ago

Ah yes, sorry I already had this fixed in a branch. I'm just running it through the suite with the latest from master then I'll merge it in. Once that's done, can you update from master and we'll see if the suite passes still :)

krzysiek1507 commented 6 years ago

Hi @brendon! I'll do it! :)

brendon commented 6 years ago

@krzysiek1507 Can you update from master, then it should be all green :)

krzysiek1507 commented 6 years ago

@brendon all green!

brendon commented 6 years ago

Thanks @krzysiek1507 :) Great job!

krzysiek1507 commented 6 years ago

Thank you!