Methods move_to_bottom and move_to_top should not fail when there are unique constraints

brendon / acts_as_list

An ActiveRecord plugin for managing lists.

http://brendon.github.io/acts_as_list/

MIT License

2.05k stars 356 forks source link

Methods move_to_bottom and move_to_top should not fail when there are unique constraints #320

Closed faucct closed 6 years ago

brendon commented 6 years ago

Thanks @faucct, can you quickly give a bit of context for this? It seems to make sense though.

faucct commented 6 years ago

There is not much context: the methods are failing when there are unique constraints.

brendon commented 6 years ago

Ah ok, so the test suite is a bit inadequate. Would you like to look at seeing if you can configure the base suite to run again with the unique constraints to see if there are any other bugs like this? I'll accept this PR for now.

faucct commented 6 years ago

Would you like to look at seeing if you can configure the base suite to run again with the unique constraints to see if there are any other bugs like this?

I don't think I will be able to find any time for this.

brendon commented 6 years ago

No worries.

faucct commented 6 years ago

Could this get a version bump, please?

brendon commented 6 years ago

All done :)