search

brendon / acts_as_list

An ActiveRecord plugin for managing lists.
http://brendon.github.io/acts_as_list/
MIT License
2.05k stars 356 forks source link

refactor a rick implement for quoted time now #353

Closed qinmingyuan closed 4 years ago

qinmingyuan commented 5 years ago

As title describe, old implement cased bugs in STI use case;

brendon commented 5 years ago

Thanks @qinmingyuan, could you give me some more details about how it fails for STI? We'll also need a failing test that passes with your changes to confirm the fix :)

brendon commented 5 years ago

Hi @qinmingyuan, just pinging you on this. We'll just need a failing test case that this PR fixes before we can merge :)

qinmingyuan commented 5 years ago

Sorry for my slowly response, I will soon give an open source engine for fails test and fixed test.

brendon commented 4 years ago

Hi @qinmingyuan, not sure what you were up to here :) Did you manage to fix the problem?