Closed davidcelis closed 3 months ago
Agreed! Sorry about that 😳 This gem is terrible for stomping all over the model namespace in various ways! Most of it was from before my time thankfully :D
Released as 1.2.1.
Oh, awesome! Thanks so much for releasing the fix so quickly 🎉
No worries at all :)
We ran into an issue with using
acts_as_list
on models that define aconnection
method or have aconnection
association (we have several). Any model with aconnection
association, for example, was raising an error onsave
as soon asacts_as_list
was added:This turned out to be because our
connection
association was being re-defined byacts_as_list
with adelegate :connection, to: :self
. Rails has no underlying problems with models having aconnection
instance method, and I believe typically you should be relying on the class to grab a connection rather than the instance/record.Because it seems like this delegator is used only for convenience purposes, I think it should be dropped for compatibility reasons and replaced with more explicit calls to
self.class.connection