brendon / ranked-model

An acts_as_sortable/acts_as_list replacement built for Rails 4+
https://github.com/mixonic/ranked-model
MIT License
1.09k stars 134 forks source link

Github Actions for CI #162

Closed janklimo closed 3 years ago

janklimo commented 4 years ago

I took a shot at moving the CI pipeline to Github Actions to see if it adds value to the project. Seeing two benefits right now:

  1. Faster builds. Taking less than 30 minutes (example), so faster than Travis despite running more jobs.
  2. More flexibility defining services. E.g. testing on MySQL 8 which isn't available on Travis afaik.

Notable changes:

  1. Updated lockfiles and moved them back into version control. This is to enable caching in CI based on checksums of these files.
  2. Added Ruby 2.7 to the matrix.

Future work:

  1. Couldn't make MySQL work with JRuby. Since I don't use either of those, it would be nice to get help from contributors who do.
  2. Testing on MySQL 8 breaks due to invalid SQL. Again, I'd like to get eyes on it from some MySQL users.

Screen Shot 2020-01-11 at 5 51 58 PM

Interested in migrating or sticking to Travis?

brendon commented 4 years ago

Thank you @janklimo, this is great work. I'm definitely happy to switch if it's faster than travis. I'm currently on holiday at the moment but will mark this to look at once I return in a week or so. Feel free to update things if you find solutions to any of your problems :)

brendon commented 4 years ago

Hi @janklimo, for jruby, I think you just need to use the correct version of the https://github.com/jruby/activerecord-jdbc-adapter gem vs Rails version. Same goes for Postgres and sqlite I think.

For the SQL error, I don't use MySQL with this gem either, but my hunch is that that integer value is outside of the default limits for MySQL 8? Though you'd think the error would be different :)

Are you happy to keep tapping away at this one?

brendon commented 4 years ago

https://stackoverflow.com/a/17783287/129798

brendon commented 3 years ago

Hi @janklimo, just checking you're abandoning this one? :)

janklimo commented 3 years ago

Hi @brendon yup, cleaning up my PR list. Unfortunately won't have the time to focus on this.

brendon commented 3 years ago

I know the feeling!