1ming
commented
1 week ago @dhsteve are you able to share a link to the repo for your calculator? i've been experimenting with an alternate algorithm for the flame calculator in my fork of this repo and and am seeing the issue you mentioned along with some other discrepancies. it would be nice to cross reference results with yours too if possible.
So I was designing my own flaming calculator independently and I'm nearly finished but was using yours as a cross reference and I wanted to make sure the average flames were aligned. So as a test to keep it simple, I'm using black flames, and the standard 10 main stat = 1% All, 3 main stat = 1 atk, 12 secondary = 1 main stat.
For flame scores 170 to 184 (the absolute maximum) my calculations matched yours exactly. However, at 169 flame score there was a discrepency.
There are either three or four possible outcomes that lead to 169 flame score, depending on how you round. Assume I'm an Aran, or any non-Demon Avenger warrior, and working with a CRA level 150 gear and black flames:
STR Only T6, STR + DEX T7, ATT T7, All Stat T7: 48 + (28 + 28/12) + 21 + 70 = 169.33 STR Only T7, STR + DEX T5, ATT T7, All Stat T7: 56 + (20 + 20/12) + 21 + 70 = 168.66 <- discrepancy STR Only T7, STR + INT T7, ATT T5, All Stat T7: 56 + 28 + 15 + 70 = 169 STR Only T7, STR + LUK T7, ATT T5, All Stat T7: 56 + 28 + 15 + 70 = 169
Only the 3 of the 4 that are 169 <= x < 170 are considered 169 flame based on the average flames calculator, in other words the floor function is used. The remaining one is considered 168.
But when you manually enter the stats in the stats checker, 76 main stat, 20 secondary stat, 7 ATT, and 7% All Stat, instead of keeping with consistency and doing the floor function, you round the summed 168.66 score up to 169.
And that messed with me for a while but I thought I'd let you know about the inconsistency. The solution would be to either change the manual stats checker to also be floor function, or change the average/median flames calculator to use rounding.