brennacodes / unruley

A VS Code extension to help visualize ruler violations
https://marketplace.visualstudio.com/items?itemName=brennacodes.unruley
GNU General Public License v3.0
0 stars 0 forks source link

Changing default unruley.ruler setting overwrites all editor.rulers #1

Closed datalot-369 closed 3 months ago

datalot-369 commented 3 months ago

Describe the bug Whenever you save the settings.js file with the unruley.ruler propertie, the editor.rulers deletes whatever it has and sets only the specified at unruley.ruler. This is both a duplication of the value and an arbitrary decision/bug.

Steps to Reproduce

  1. Go to settings.js
  2. Set:
    "editor.rulers": [
        {"column": 72},
        {"column": 80},
        {"column": 100}
    ],
    "rulery.ruler": 100
  3. Ctrl + S

Expected behavior Only characters that cross the 100 limit get red-colored, no matter what other rulers are set.

Actual behavior editor.rulers get overwritten.

Configuration Info:

Version: 1.89.1
Commit: dc96b837cf6bb4af9cd736aa3af08cf8279f7685
Date: 2024-05-07T05:16:23.416Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 6.8.11-300.fc40.x86_64
brennacodes commented 3 months ago

@datalot-369 Taking a look into this and your other submission now and will update once it's resolved.

brennacodes commented 3 months ago

Closing. Reference https://github.com/brennacodes/unruley/issues/2