search

brennerm / aws-quota-checker

Keep an eye on your AWS quotas before you hit their limits
https://pypi.org/project/aws-quota-checker/
MIT License
87 stars 37 forks source link

add check for target groups per alb #18

Closed mgreschl closed 3 years ago

mgreschl commented 3 years ago

Addresses #17.

This PR also has some auto formatting done by black of elb.py. If this formatting isn't desired I can back out those changes.

brennerm commented 3 years ago

Hey @mgreschl, thanks for submitting this PR and the according issue.

I'm fine with the formatting changes except the usage of double quotes. Would appreciate if you could use single quotes if that's not a big deal to you.

If you could add a changelog entry describing your change we would be good to merge from my side.

Thanks for your work!

mgreschl commented 3 years ago

@brennerm done! I didn't change the key and description fields from double to single because they were that way prior to the auto formatting. I can change those to singles if that's prefered.

brennerm commented 3 years ago

Nah, that's fine. Will take care of that. :)

Appreciate your work. Will release it shortly. :+1: