Version 1.10.0 - Githubissues

brennerm / aws-quota-checker

Keep an eye on your AWS quotas before you hit their limits

https://pypi.org/project/aws-quota-checker/

MIT License

87 stars 37 forks source link

Version 1.10.0 #30

Closed alt-dima closed 2 years ago

alt-dima commented 2 years ago

Added

fix MaxResults=1000 for EC2 instances check (from baec59a)
new checks: ecsstrg_count,fargatespot_count,fargatedemand_count,iam_role_count (from #23)
added service/quota_code: iam_user_count
fixed description: s3_bucket_count
feature: display NOTDEF for check if limit in AWS is not default (was increased)
catch EndpointConnectionError

alt-dima commented 2 years ago

This PR just in case if somebody also needs feature to display NOTDEF for check if limit in AWS is not default (was increased)

brennerm commented 2 years ago

Hey @alt-dima, thanks for your work! I'd like to ask you to remove the NOTDEF indication including all the relevant code for now as I don't agree with the current implementation. Maybe create an issue prior to making these kinds of changes to discuss this topic before spending your valuable time. :)

alt-dima commented 2 years ago

Ok! No problem:) I have a task on my job to quickly find any changed/increased quotas/limits in our AWS accounts. And also learn some python. I will move NOTDEF stuff to a brach

brennerm commented 2 years ago

@alt-dima No need to close the PR. You can just revert your changes, push to the same branch and the PR will update.