brennerm / aws-quota-checker

Keep an eye on your AWS quotas before you hit their limits
https://pypi.org/project/aws-quota-checker/
MIT License
87 stars 37 forks source link

Add RDS snapshot quota checks #33

Closed kedoodle closed 2 years ago

kedoodle commented 2 years ago

Adds quota checks for Manual DB cluster snapshots and Manual DB instance snapshots https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/CHAP_Limits.html#RDS_Limits.Limits image

$ aws-quota-checker check rds_db_snapshots,rds_db_cluster_snapshots
AWS profile: default | AWS region: ap-southeast-2 | Active checks: rds_db_cluster_snapshots,rds_db_snapshots
Collecting checks  [####################################]  100%
Manual DB cluster snapshots per Region [xxx/ap-southeast-2]: 0/200 ✓
Manual DB instance snapshots per Region [xxx/ap-southeast-2]: 152/200 ✓
brennerm commented 2 years ago

@kedoodle Thanks again for your PR! Looking good

Do you mind renaming the check keys as follows? rds_db_snapshots -> rds_instance_snapshots rds_db_cluster_snapshots -> rds_cluster_snapshots

kedoodle commented 2 years ago

Hey @brennerm,

Appreciate the acceptance of these PRs! I have updated the keys as suggested.

aws-quota-checker check rds_instance_snapshots,rds_cluster_snapshots                   
AWS profile: default | AWS region: ap-southeast-2 | Active checks: rds_cluster_snapshots,rds_instance_snapshots
Manual DB cluster snapshots per Region [xxx/ap-southeast-2]: 0/100 ✓
Manual DB instance snapshots per Region [xxx/ap-southeast-2]: 31/100 ✓

I wasn't able to figure out a single naming convention for the keys. Many have _count suffixes, some have _per_*, and some are just plurals. I like the plurals, as in this PR:

brennerm commented 2 years ago

@kedoodle Agree, will align them in the next major version. Thanks again for your support!

brennerm commented 2 years ago

Change has been released in version 1.12.0.