brennerm / check-mk-web-api

Python library to talk to the Check_Mk Web API
https://brennerm.github.io/check-mk-web-api/
MIT License
53 stars 26 forks source link

invalid pattern for matching service discovery stats #22

Closed jongeneel closed 4 years ago

jongeneel commented 4 years ago

Thanks for all the good work, this module saved me a lot of time. I found an issue in the result of the discover_services introduced in a previous change.

Currently it returns {'added': '0', 'removed': 'R', 'kept': 'K', 'new_count': '905'} While it should return {'added': '0', 'removed': '0', 'kept': '905', 'new_count': '905'}

The solution is to change the regex __DISCOVERY_REGEX patterns to return only one group

brennerm commented 4 years ago

Thanks for submitting this. 👍 Will have a look at it in the evening.

brennerm commented 4 years ago

LGTM, thanks again :+1: