search

brennerm / check-mk-web-api

Python library to talk to the Check_Mk Web API
https://brennerm.github.io/check-mk-web-api/
MIT License
53 stars 26 forks source link

Bulk discovery #34

Closed cboseck closed 3 years ago

cboseck commented 3 years ago

Added support for the bulk-discovery. Is faster than doing discover_services_for_all_hosts because it uses the check_mk build in mechanism.

brennerm commented 3 years ago

Thanks for adding! Seems like thats another operation that is not documented but I'm fine with adding it.

Unfortunately the methods aren't available for CheckMK 1.5 (see CI run) so we need to add some condition to skip these tests. Do you want to take care of this?

cboseck commented 3 years ago

Thanks for adding! Seems like thats another operation that is not documented but I'm fine with adding it.

Unfortunately the methods aren't available for CheckMK 1.5 (see CI run) so we need to add some condition to skip these tests. Do you want to take care of this?

How would you do it, my idea is to add a env-variable with the check_mk version

brennerm commented 3 years ago

Thanks for adding! Seems like thats another operation that is not documented but I'm fine with adding it. Unfortunately the methods aren't available for CheckMK 1.5 (see CI run) so we need to add some condition to skip these tests. Do you want to take care of this?

How would you do it, my idea is to add a env-variable with the check_mk version

Agree :+1: Ideally we could pull version information from the API but I don't know an endpoint that delivers this info. Introduce a variable like CHECK_MK_VERSION and only if its value is "1.5" skip the tests.

cboseck commented 3 years ago

Thanks for adding! Seems like thats another operation that is not documented but I'm fine with adding it. Unfortunately the methods aren't available for CheckMK 1.5 (see CI run) so we need to add some condition to skip these tests. Do you want to take care of this?

How would you do it, my idea is to add a env-variable with the check_mk version

Agree +1 Ideally we could pull version information from the API but I don't know an endpoint that delivers this info. Introduce a variable like CHECK_MK_VERSION and only if its value is "1.5" skip the tests.

2c39ef96497a2d95618bdac99514957ce6b42422 should to the trick

brennerm commented 3 years ago

Great work, thanks! Will include it in the next release. :+1: