search

brenns10 / lsh

Simple shell implementation. Tutorial here ->
http://brennan.io/2015/01/16/write-a-shell-in-c/
The Unlicense
1.47k stars 340 forks source link

For builtins, use an array of structs. #8

Closed ssilva closed 7 years ago

ssilva commented 7 years ago

(instead of two parallel arrays)

brenns10 commented 7 years ago

From the README:

Since this is the subject of a tutorial, I'm not looking to extend it with additional features at this time. So I won't be accepting any pull requests that aren't related to bug fixes (and I'm sure there are still bugs in the code!).

The shell and tutorial are pretty much a finished product. I'd prefer not to modify them unless they contain an error.

The struct approach is definitely better, and I'd encourage you to continue improving and extending the shell. But this repo is just a place for the tutorial code to live, serving as a place for all the readers to jump in and start their own improvements.

Hope you understand!

ssilva commented 7 years ago

No worries, thanks again for the tutorial!