brennsch / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #1

Open gdedi001 opened 7 years ago

gdedi001 commented 7 years ago

Grade: Exceeds Expectation

Great job on your project - I loved how you were able to incorporate the <p> and <h2> tag making your HTML very neat! In addition to this, you utilized the <font> tag where you incorporated the blue font color. These two aspects of your code helped you meet the design requirements! An area for improvement here is with respect to your implementation of the class attribute in some cases you used it incorrectly.

A recommendation here is to review the following article. Try applying the concept and its usage. It will aid you as your projects get more complex. Read it thoroughly and view the examples! Keep up the great work! id vs. class

brennsch commented 7 years ago

Hello,

Could you be more specific about how I used the class attribute incorrectly? I used the class attribute three times and used it the exact way each time. I reviewed the article but am still confused. Do you mean that I should have used an id instead of a class attribute?

Thank you!

gdedi001 commented 7 years ago

Yup in your case you should have opted for id instead. Even though you used the class attribute 3 times, they have only been used once, and as a result, are unique. Anytime we have uniqueness go for id