refactor wired save packet handling - [merged]

[brenoepics]

In GitLab by @skeletor on Mar 21, 2022, 23:39

Merges refactor/wired-saving -> dev

While solving reported bugs on nitro we discovered that sometimes morningstar sends wrong data for certain wireds. Nitro was accepting this data without questioning, and then sending it back to morningstar on room reload/wired saving/etc, and morningstar would have problems parsing back this data because of the way that wired packet handling was done. This merge request fixes the parsing so that it is more consistent and follows the swf format.

The bug was present in the wireds mentioned in the following issue: https://git.krews.org/nitro/nitro-react/-/issues/168

As you can see below, Morningstar was sending the array [0] as intParams, but then when nitro sent that same thing back, it did not handle parsing it correctly since it was not expecting any intParams, causing errors while attempting to save that wired.

[brenoepics]

In GitLab by @skeletor on Mar 22, 2022, 22:49

added 1 commit

• e3b0c62d - fix wired condition furni has avatars sending wrong data

Compare with previous version

[brenoepics]

In GitLab by @Harmonic on Apr 10, 2022, 15:19

mentioned in commit 9c4b1df499f6b60d2fe9479057ba8c661aeaaf01

[brenoepics]

In GitLab by @Harmonic on Apr 20, 2022, 20:55

mentioned in commit d3762c9b87e646978e4da4fb357a4097e77d0abd