search

brenoepics / morningstar

An open-source Arcturus Community Fork.
GNU General Public License v3.0
3 stars 2 forks source link

Improvement: Voucher Error #72

Closed brenoepics closed 1 year ago

brenoepics commented 5 years ago

In GitLab by @KingdomPower on May 13, 2019, 19:23

Voucher alert doesn't show the message

Expected Behavior

https://cdn.discordapp.com/attachments/576201313281507375/577613602509291550/unknown.png

Current Behavior

https://cdn.discordapp.com/attachments/576201313281507375/577611993356435470/unknown.png

Possible Solution

Check my repo, I already solved it just by casting error code from Int to String. (It could be improved by changing all the function calls) https://git.krews.org/KingdomPower/arcturus-itsgiuseppe/commit/9a00d17f33909fecb23f7127bbb1c1da06139ce9

Steps to Reproduce

  1. Open catalogue
  2. Insert into voucher box a wrong voucher

    Context (Environment)

Detailed Description

Possible Implementation

The problem is that the SWF expects an error code as String but the emulator gives him an integer.

brenoepics commented 5 years ago

In GitLab by @Harmonic on May 14, 2019, 10:50

Oh.. I fixed this just by adding those texts to external.texts.. LMAO.

brenoepics commented 5 years ago

In GitLab by @KingdomPower on May 14, 2019, 18:43

Its just a workaround fix! xD The emulator send a request that is incompatible with SWF.

brenoepics commented 5 years ago

In GitLab by @beny-archive on May 15, 2019, 18:56

Hello. I can't access your repo. Please make a merge request or send us a snippet :)

brenoepics commented 5 years ago

In GitLab by @ghost on May 18, 2019, 10:27

Fixed in 1eddce95460182564c1226273f83b28689f4726f

brenoepics commented 5 years ago

In GitLab by @ghost on May 18, 2019, 10:27

closed