search

brenoprata10 / nvim-highlight-colors

Highlight colors for neovim
654 stars 31 forks source link

fix!: remove redundant space in virtual text #83

Closed delphinus closed 3 months ago

delphinus commented 3 months ago

I want to set virtual symbol with inline render option. The current code automatically adds ' ' (space) after the symbol, but I want the exact one to insert.

This may become a breaking change, so we should add a note for this, perhaps.

brenoprata10 commented 3 months ago

After a few days thinking about this PR, I've reached the conclusion that it's best to create a new property e.g. virtual_text_suffix, that will hold this empty space by default and also allow you to customize at your own accord. Unfortunately, we need to have that empty space by default, and we cannot handle it like you did here, because if someone changes their virtual text symbol, they will probably not add the empty space at the end. Which will force them to read the docs or create an issue.

I will get to this during the weekend.

delphinus commented 3 months ago

I agree your plan. I will see your diff and then close here. Thank you.

brenoprata10 commented 3 months ago

I've just pushed the code with the change, please update the plugin and feel free to create an issue if you find any bugs :)