brentd / xray-rails

☠️ A development tool that reveals your UI's bones
MIT License
1.22k stars 79 forks source link

Drop support for Ruby <=2.4 (and Rails 4?) #109

Open TylerRick opened 3 years ago

TylerRick commented 3 years ago

Support of Ruby 2.4 has ended so we should stop wasting time officially supporting it and remove it from .travis.yml.

See also https://github.com/rails/sprockets/pull/672 / https://github.com/rails/sprockets/pull/604/files, which also made Ruby 2.5 the minimum version.

While we're at it, can we drop support for Rails 4, and only supporting 5.2 and up going forward?

If someone really wants to use an old version of Ruby/Rails, they can lock to an old version of xray-rails. I've already spent too much time trying to get everything (mostly tests) to work in all versions as part of https://github.com/brentd/xray-rails/pull/101, but I regret wasting my time doing so. The correct choice would be to just drop support for ancient versions and spend what little time we have supporting current/future versions.