search

brentd / xray-rails

☠️ A development tool that reveals your UI's bones
MIT License
1.22k stars 79 forks source link

Turbolinks causes UI Bar to disappear #37

Closed 2called-chaos closed 9 years ago

2called-chaos commented 10 years ago

I use turbolinks in one of my projects and I noticed that when you change the page xray keep working but the control bar at the bottom is gone.

It is not a big deal since I can simply refresh the page but maybe it's an easy fix.

Best Sven

brentd commented 10 years ago

Thought this might happen. It's because turbolinks is blowing away the xray bar which is added via middleware. Not sure the best way to fix this just yet.

brentd commented 10 years ago

I'm going to attempt a new project with turbolinks soon, so I'll likely be checking into this.

brentd commented 10 years ago

Ended up removing Turbolinks because I didn't want to figure out how to bandaid each jquery plugin I was using. But this should just be a matter of subscribing to Turbolinks' custom page load events.

2called-chaos commented 10 years ago

Yeah there are some gotchas and a lot of plugins do (in a lot of cases even senseless) stuff which would need separation between full and "soft" page initialization. It is a bit tedious but I think it is worth it :)