brentkrueger / VisualStudio2015PackageVisualizer

Implementation of the Visual Studio 2013 package visualizer as a Visual Studio 2015 extension. Version for VS 2017 can be found here: https://github.com/brentkrueger/VisualStudio2017PackageVisualizer

MIT License

13 stars 3 forks source link

Bugfix: correctly get projects in solution folders #3

Closed wangzq closed 7 years ago

wangzq commented 8 years ago

Hello, thank you for your contribution! Can you please provide a quick example of what this pull request accomplishes or fixes, versus what the plugin does now? That way I can verify it's all working correctly and accept your request. thank you!

mistoll commented 7 years ago

Please merge this. In some solutions the current implementation does not generate a graph (blank output). This is fixed by this PR.

wangzq commented 7 years ago

Looks like I missed the first comment, yes this PR is used to handle solutions with projects in solution folders. You should be able to repro and verify this by just moving any projects into solution folders.

brentkrueger commented 7 years ago

Hi wangzq,

I was able to reproduce the issue, by adding a project directly into the solution folder like you mentioned. However, the PR didn't seem to resolve this, unless I'm missing something? I patched with your PR locally, and debugged to ensure that your new DTE class was being used etc, still seeing the sequence contains more than one element exception. Could you send me a message at vs2015packagevisualizer@kruegerwebdesign.com and we can work together on this? thanks

mistoll commented 7 years ago

AFAIK, the "sequence contains more than one element" issue (#4) is NOT related to this PR.

This PR handles the location of the projects within a solution.

4 is triggered by different versions of installed nuget packages in the projects of a solution.

The latter does not change with this PR.