search

brentley / appmeshworkshop

23 stars 45 forks source link

build-containers #104

Open jinseo-jang opened 4 years ago

jinseo-jang commented 4 years ago

in build-containers scripts, docker build command should be adjusted to find proper Dockerfiles. docker build -t crystal-service ../ecsdemo-crystal or docker build -t crystal-service ~/environment/ecsdemo-crystal

jeeslo commented 4 years ago

Is this an actual issue or an improvement? If I am not mistaken, following the workshop instructions you are intended to run the generated script from the ~/environment path, hence the docker build commands work as expected. In any case, I agree that its a quick change that could avoid the script failing out should someone decides to run it from somewhere else.

jinseo-jang commented 4 years ago

yes. it can be an improvement in case learners are just lost where to execute that script.