brentley / ecsworkshop

25 stars 98 forks source link

[FEATURE] Working with Secrets in ECS - WIP PR #151

Closed ghost closed 3 years ago

ghost commented 3 years ago

Resolves #151 - new branch of new chapter on Secrets in ECS ready for review

adamjkeller commented 3 years ago

Ran through the copilot section, will run through cdk tomorrow.

In general this covers quite a bit and is thorough. I would prefer to see all of the deployment steps and code reviews on a single page like we do for the microservices section of the workshop (frontend for example). Also, more commentary around the how with copilot will show the true magic behind the tool and how much it abstracts away from the user.

ghost commented 3 years ago

Latest commit reflects changes requested.

ghost commented 3 years ago

Latest commit reflect revisions requested.

adamjkeller commented 3 years ago

LGTM, thanks @mptaws !!