search

brentonashworth / clj-diff

Diff for Clojure Sequences
Eclipse Public License 1.0
114 stars 23 forks source link

Replace nil with explicit sentinel for diff and patch #8

Open pithyless opened 5 years ago

pithyless commented 5 years ago

Nil is a valid value in a sequence, but was used as an iterator marker, causing program to hang. Similarly, patch used nil as a deletion-marker.

This commit replaces both nil uses with explicit sentinel values.

terjedahl commented 5 years ago

I suggest making your PR to https://github.com/droitfintech/clj-diff instead. They have a non-SNAPSHOT release of a fork and are clearly the communities preferred version. (9000+ downloads vs this SNAPSHOT deployment at 2000+).

pithyless commented 5 years ago

FYI: This was fixed and released in community fork: [tech.droit/clj-diff "1.0.1"]