search

brentp / bwa-meth

fast and accurate alignment of BS-Seq reads using bwa-mem and a 3-letter genome
https://arxiv.org/abs/1401.1129
MIT License
139 stars 53 forks source link

Relax Python version restrictions #4

Closed superbobry closed 10 years ago

superbobry commented 10 years ago

Is it possible to support >=Python2.6?

Update: bellow is a list of Python2.7 features I've spotted in the code

  1. The use of argparse, which is only available in Python2.7. This can be fixed by adding a conditional dependency on argparse in setup.py.
  2. toolshed/files.py and toolshed/pool.py assume sys.version_info is a namedtuple. This is easily fixed by using plain indexing, eg. sys.version_info[0].
brentp commented 10 years ago

I'd accept a pull-request to toolshed for this but probably won't get to it myself. I guess people are still using python 2.6? darn.

superbobry commented 10 years ago

CentOS6 has Python2.6 and it's unlikely to change unfortunately. I'll submit a PR in the next few days.