search

brentp / bwa-meth

fast and accurate alignment of BS-Seq reads using bwa-mem and a 3-letter genome
https://arxiv.org/abs/1401.1129
MIT License
144 stars 54 forks source link

The link in `README.md` of the `compare/` folder is not working #74

Closed xie186 closed 2 years ago

xie186 commented 2 years ago

Hi @brentp , the link here (https://copy.com/jxoJKLOhWzjz) seems not working anymore. I would like to try the performance of dragmap on BS-seq reads (https://github.com/xie186/dragmap-meth). I would like to use bwa-meth as a base to compare. Could you please update the link if the data is still available when you get a chance? Thanks.

brentp commented 2 years ago

Hi, unfortunately that data is no longer available to me. I have tried to get it from the old institution, but that is not possible.

I'm glad to see you using bwa-meth code and you're certainly welcome to do so. Perhaps, you might consider a more prominent and accurate notification of how you used bwa-meth code since the major and important parts are taken literally from there.

xie186 commented 2 years ago

Thank you for the quick response. Then I'll simulate the read with Sherman. Yes. I totally agree with you about the notification. I learned a lot while reading your code. Thank you. Do you mind if I add you as a contributor to dragmap-meth? You can also update the READMEME.md file and codes if you have any suggestions.

brentp commented 2 years ago

I think adding me as a contributor is overly generous and not necessary. A more clear indication that a good portion of the code is directly copied from bwa-meth does not detract from your work, credits mine, and gives more info on the provenance. Nice work BTW!

xie186 commented 2 years ago

Thanks you. I'll email you about the contributor topic and how to give the provenance.