Closed fabio-t closed 6 years ago
It should also fix this issue, by the way: https://github.com/brentp/fishers_exact_test/issues/17
@brentp just a gentle nudge :) have you had the time to look at this?
sorry. I completely missed this. Thanks.
@brentp thanks!
Right now, to install this package one has to install numpy before. That's because of
import numpy as np
which is called even for a command such as egg_info, which pip uses to find dependencies.This PR accomplishes two things:
uses setuptools instead of distutils which is "deprecated" (a wrapper to setuptools essentially, if I understand it correctly). This also seems required for the next step (seems like doing this with distutils doesn't work).
calls
numpy.get_include()
only when doing actual build/install, not with other setup commands. This allows egg_info to run smoothly and for pip to fetch numpy as a dependency before attempting to build fisher.