Closed shouldsee closed 5 years ago
this looks fine to me. can someone else (@tanghaibao ?) take a look? @shouldsee please remove the code rather than commenting it out.
Just some minor stylistic suggestion, but otherwise good to go. Thanks -
thanks @shouldsee and Haibao
use
setuptools.setup(setup_requires=[”numpy“])
to specify build-time dependency.Feel free to test this without disutils.