Make `setup.py` cythonize the extensions when building

brentp / fishers_exact_test

Fishers Exact Test for Python (Cython)

BSD 3-Clause "New" or "Revised" License

62 stars 21 forks source link

Make `setup.py` cythonize the extensions when building #37

Closed althonos closed 2 years ago

althonos commented 2 years ago

As discussed in #36 this PR implements automatic cythonization of the fisher.cfisher extension when python setup.py install or pip install is being executed.

I unstaged + .gitignore'd the C file because it's not needed anymore, a new one will be generated at any time so there is no point version-tracking it.

brentp commented 2 years ago

Thanks very much, can you commit without the cfisher.c ? I'll cythonize and add that so I'm sure it's not introducing any bitcoin miners or something.

althonos commented 2 years ago

Sure thing! If you just run python setup.py build_ext -f it will overwrite the local file.

brentp commented 2 years ago

thanks very much! I, add cfisher.c, tagged v0.1.10 and pushed.

althonos commented 2 years ago

Perfect! Thanks for the prompt responses :smile: