search

brentp / fishers_exact_test

Fishers Exact Test for Python (Cython)
BSD 3-Clause "New" or "Revised" License
62 stars 21 forks source link

Fix `versioneer` prefix in `setup.cfg` #43

Closed althonos closed 9 months ago

althonos commented 9 months ago

Okay I found the bug, versioneer uses a glob pattern to identify tags which seems to fail if the tag_prefix key is empty. I did a test run on my end and now the wheels have the proper tag.

althonos commented 9 months ago

Guess now you only need to update the upload phase with to use an ID token: https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/ and make sure you create a trusted publisher on PyPI

brentp commented 9 months ago

it's actually uploading all the wheels which I think are available, but it's failing some how on the tar.gz thinking it's a duplicate. image

althonos commented 9 months ago

Aaah perfect! Yeah it's not impossible the tar.gz was uploaded earlier in a previous step while the wheels were failing, so that should be fine. Thanks again for taking care of this today!

brentp commented 9 months ago

I don't see a tar.gz in the file list. /shrug

althonos commented 9 months ago

:( Would you mind trying a v0.1.13? If the filename was already used it will not be possible to upload a new archive without making a new release

brentp commented 9 months ago

tagged

althonos commented 9 months ago

:crossed_fingers:

althonos commented 9 months ago

Looks like you can't tag the same commit twice otherwise versioneer will use the older tag :open_mouth:

althonos commented 9 months ago

All clear finally, thanks again :smile:

brentp commented 9 months ago

thank you!