search

brentp / goleft

goleft is a collection of bioinformatics tools distributed under MIT license in a single static binary
MIT License
216 stars 25 forks source link

Release Linux aarch64 binary #75

Closed martin-g closed 7 months ago

martin-g commented 7 months ago

I'd like to request a release of Linux ARM64/Aarch64 binary in addition to the Linux x86_64 and Mac OSX Intel ones.

Since few months Bioconda officially supports linux-aarch64. Currently the recipe uses the released binaries - https://github.com/bioconda/bioconda-recipes/blob/master/recipes/goleft/meta.yaml#L8-L11. I could add logic to build from sources if needed too!

brentp commented 7 months ago

Hi @martin-g , I am happy to add this. Do I simply use this:

CGO_ENABLED=0 GOARCH=arm64 go build -o goleft_arm64 --ldflags '-extldflags "-static"' cmd/goleft/goleft.go

to compile? I think that will build for linux/arm64. Not sure if the OS matters.

martin-g commented 7 months ago

Hi @brentp !

I think your command should be OK if you execute it on Linux. If you run it on another OS (e.g. Mac OS or Windows) then you should add GOOS=linux too.

martin-g commented 7 months ago

https://github.com/brentp/vcfanno/releases/download/v0.3.5/vcfanno_linux_aarch64 - here you used aarch64 as a suffix. I think it is a better suffix for Linux. You can use arm64 for darwin (Mac OS) later if requested.

-o goleft_linux_aarch64

brentp commented 7 months ago

ok. I just added it to the existing release: https://github.com/brentp/goleft/releases/tag/v0.2.6

thanks for bringing this up and for the help!