brentp / pbr

drunk on perbase pileups and lua expressions
MIT License
17 stars 2 forks source link

enh: filter tags #7

Open y9c opened 1 year ago

y9c commented 1 year ago

Will it be useful to add filter for tags, such as "[NH]>1" to filter reads of multiple hits? Will the same grammar as --input-fmt-option of samtools help?

Thank you.

brentp commented 1 year ago

I like this idea. It would be lua syntax, like read.NH > 1 or more likely tag.NH > 1.

brentp commented 1 year ago

is this or any other issue blocking for you? I probably can't implement everything right now, but would like to get the top priorities started.

y9c commented 1 year ago

Thank you @brentp, filtering by tags should be one of the prior features I wish to have.

Another two major things are:

y9c commented 1 year ago

Hi @brentp, thank you for working on this. I would like to known if filtering by tags is supported now?

brentp commented 1 year ago

No, for now, I have put this project on hold. I think there is too much overhead in calling a lua expression for each base. Maybe it's possible with using some kind of macro based expressions within rust, but I don't have plans to implement further. I found that using pysam with custom code is faster than pbr.