brentp / somalier

fast sample-swap and relatedness checks on BAMs/CRAMs/VCFs/GVCFs... "like damn that is one smart wine guy"
MIT License
255 stars 35 forks source link

Some grouped pairs in groups.csv shown as 'unrelated' in .html #14

Closed JosephMcCarter closed 5 years ago

JosephMcCarter commented 5 years ago

In a cohort of 500 samples, some samples pairs were marked as unrelated despite being grouped in the grouped.csv file.

for example

grep 133675 somalier_groups_impact_independant.csv
I-H-133675-T3-1-D1-1,I-H-133675-N2-1-D1-1,I-H-133675-T4-1-D1-1,I-H-133675-T5-1-D1-1,I-H-133675-T6-1-D1-1,I-H-133675-T7-1-D1-1,I-H-133675-T8-1-D1-1,I-H-133675-T9-1-D1-1,I-H-133675-T10-1-D1-1,I-H-133675-N2-2-D1-1

Screen Shot 2019-03-27 at 4 44 34 PM

brentp commented 5 years ago

can you share the html file?

brentp commented 5 years ago

or from the js console, can you show the output of:

input["expected-relatedness"]
JosephMcCarter commented 5 years ago

Here is the .html

p230_somalierrun2.somalier.html.zip

brentp commented 5 years ago

great. thank you. I have fixed this. See attached (I just hand-edited your html and made same fix in somalier). fix.zip

brentp commented 5 years ago

can you verify that HTML looks good to you? I have finished up some other dev and it's getting close to a new release for somalier. thanks again.

JosephMcCarter commented 5 years ago

Thank you!

On Wed, 27 Mar 2019 at 17:54, Brent Pedersen notifications@github.com wrote:

Closed #14 https://github.com/brentp/somalier/issues/14 via 01166c0 https://github.com/brentp/somalier/commit/01166c0db115bff189340eeb7d2d2ef24bb9022a .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/brentp/somalier/issues/14#event-2234613024, or mute the thread https://github.com/notifications/unsubscribe-auth/AYT0CH8o_ho_TRHyV1XcIyBBxViP38OAks5va-iPgaJpZM4cOwXR .

JosephMcCarter commented 5 years ago

html for this specific issue looks good! - Thank you

however - I just noticed another in #15