brentthorne / posterdown

Use RMarkdown to generate PDF Conference Posters via HTML
https://brentthorne.github.io/posterdown_html_showcase/
Other
838 stars 129 forks source link

links-to-footnotes option does not work #102

Open jooyoungseo opened 4 years ago

jooyoungseo commented 4 years ago

currently, links-to-footnotes option that is available in pagedown::html_paged() does not work for posterdown output.

Would it be possible to make it work? Please refer to the following reproducible code:

---
output: posterdown::posterdown_html
links-to-footnotes: true
---

# Link to Footnote Test

See [Google](https://google.com).
brentthorne commented 4 years ago

Hello @jooyoungseo !

There is definitely a way to get this to work but I will need to kindly ask @RLesur (:pray:) for his advice. I believe that what is happening is that the functionality of footnotes is working, however I have not added the if statement in the package templates to place the footnotes when someone specifies that they want the.

Also, when I looked over the pagedown documentation, it noted that you must also include paged-footnotes: true. Although even with this added to the YAML it still does not work. I will continue to look into it but it may take a bit of time on my end because I am not well versed in the javascript hooks that pagedown uses :face_with_head_bandage:.

I am also taking open suggestions for where one would want footnotes to appear in each of the poster templates. Should they be in the references section or elsewhere? :man_shrugging:

RLesur commented 4 years ago

Hi both,

The links-to-footnotes is available in pagedown through a Pandoc lua filter.

For now, this filter is only used in pagedown::html_paged() output format. Implementing its support in pagedown::poster_relaxed() shouldn't be a complex task: you can open a feature request in the pagedown repository (https://github.com/rstudio/pagedown/issues)

However, you already can use it as follows:

---
output: 
  posterdown::posterdown_html:
    pandoc_args:
      - --lua-filter
      - !expr system.file("resources", "lua", "uri-to-fn.lua", package = "pagedown")
links-to-footnotes: true
---

# Link to Footnote Test

See [Google](https://google.com).
brentthorne commented 4 years ago

Thank you @RLesur this works well!